From 972c92540e4135534a77aa318e418806a062efc4 Mon Sep 17 00:00:00 2001 From: Daniel Bonniot Date: Wed, 3 Jul 2013 22:02:53 +0200 Subject: [PATCH] Use return in the non-handled key cases, and call preventDefault() in a single place, as suggested. https://github.com/coolwanglu/pdf2htmlEX/issues/180 --- share/pdf2htmlEX.js.in | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/share/pdf2htmlEX.js.in b/share/pdf2htmlEX.js.in index 9555913..809b4b4 100644 --- a/share/pdf2htmlEX.js.in +++ b/share/pdf2htmlEX.js.in @@ -340,7 +340,6 @@ var pdf2htmlEX = (function(){ else { _.$container.scrollTop(_.$container.scrollTop()-_.$container.height()); } - e.preventDefault(); break; case 34: // Page DOWN @@ -352,23 +351,28 @@ var pdf2htmlEX = (function(){ else { _.$container.scrollTop(_.$container.scrollTop()+_.$container.height()); } - e.preventDefault(); break; case 35: // End if (e.ctrlKey) { _.scroll_to_page(_.pages[_.pages.length-1]); - e.preventDefault(); } + else + return; break; case 36: // Home if (e.ctrlKey) { _.scroll_to_page(_.pages[1]); - e.preventDefault(); } + else + return; break; + + default: + return; } + e.preventDefault(); }); },