DenysMedvid
/
moodle-plagiarism_pchkorg
mirror of https://github.com/PlagiarismCheck/moodle-plagiarism_pchkorg.git
1
0
Fork 0
Code Releases Activity

Update lib.php "Support student custom roles" 

8862dc0 introduced a bug that caused the widget to be disabled for an excess of Moodle user roles, as they became considered "Students" as per $isstudent 

This change I believe was intentional, but to be applied where $isstudent is reassigned for the purpose of $role in auto_registrate_member($name, $email, $role)

I believe that this would have had the intended effect of avoiding real world students that don't have the specific named role 'student' on Moodle (i.e. having a custom role that uses the 'student' archetype but a different role name) from being given 'Teacher' role and permissions on plagiarismcheck.org
This commit is contained in:
Llewelyn Williams 2023-06-05 16:23:50 +01:00 committed by GitHub
parent 8862dc050a
commit 8ba5f460f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib.php
View File

@ -329,7 +329,8 @@ class plagiarism_plugin_pchkorg extends plagiarism_plugin {
$roles[] = strtolower($rolesData->shortname);
}
// Moodle has multiple roles in courses.
$isstudent = !in_array('teacher', $roles)
$isstudent = in_array('student', $roles)
&& !in_array('teacher', $roles)
&& !in_array('editingteacher', $roles)
&& !in_array('managerteacher', $roles);
@ -742,10 +743,9 @@ display: inline-block;"
$roles[] = strtolower($rolesData->shortname);
}
// Moodle has multiple roles in courses.
$isstudent = in_array('student', $roles)
&& !in_array('teacher', $roles)
&& !in_array('editingteacher', $roles)
&& !in_array('managerteacher', $roles);
$isstudent = !in_array('teacher', $roles)
&& !in_array('editingteacher', $roles)
&& !in_array('managerteacher', $roles);
$isregistered = $apiprovider->auto_registrate_member($name, $USER->email, $isstudent ? 3 : 2);
if (!$isregistered) {
return true;